Skip to content

test(chip-list): rework tests to work under Ivy #15427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2019

Conversation

crisbeto
Copy link
Member

Fixes the chip list tests that are failing under Ivy due to a known breaking change.

Fixes the chip list tests that are failing under Ivy due to a known breaking change.
@crisbeto crisbeto requested a review from jelbourn as a code owner March 10, 2019 07:09
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 10, 2019
crisbeto added a commit to crisbeto/material2 that referenced this pull request Mar 10, 2019
Equivalent of angular#15427 for master. Fixes the chip list tests that are failing under Ivy due to a known breaking change.
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please also cherry-pick this into a PR for master

@jelbourn jelbourn merged commit e766a4f into angular:ivy-2019 Mar 11, 2019
mmalerba pushed a commit that referenced this pull request Mar 11, 2019
Equivalent of #15427 for master. Fixes the chip list tests that are failing under Ivy due to a known breaking change.
crisbeto added a commit to crisbeto/angular that referenced this pull request Mar 11, 2019
Updates the blocklist to enable the tests that were fixed by angular/components#15427.

This PR resolves FW-1145.
kara pushed a commit to angular/angular that referenced this pull request Mar 11, 2019
Updates the blocklist to enable the tests that were fixed by angular/components#15427.

This PR resolves FW-1145.

PR Close #29228
mmalerba pushed a commit that referenced this pull request Mar 18, 2019
Equivalent of #15427 for master. Fixes the chip list tests that are failing under Ivy due to a known breaking change.
Suresh918 pushed a commit to Suresh918/material2 that referenced this pull request Apr 15, 2019
Equivalent of angular#15427 for master. Fixes the chip list tests that are failing under Ivy due to a known breaking change.
wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 17, 2019
Updates the blocklist to enable the tests that were fixed by angular/components#15427.

This PR resolves FW-1145.

PR Close angular#29228
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants